Skip to content

Adding documentation about BLK100 issue in D.1.12, add Visual Studio dir to .gitignore #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

Adding documentation about BLK100 issue in D.1.12, add Visual Studio dir to .gitignore #117

merged 1 commit into from
Mar 30, 2023

Conversation

@mnarus
Copy link
Contributor

@mnarus mnarus commented Mar 28, 2023

Update Coding-Conventions.md to include BLK100 for rule re: adding a line before a docstring.

@mnarus mnarus requested review from irwand and neilvana as code owners March 28, 2023 17:55
@mnarus mnarus marked this pull request as draft March 28, 2023 17:55
@github-actions
Copy link
Contributor

Thank you for contributing! 👋

@github-actions
Copy link
Contributor

Thank you for contributing! 👋

Since this changes the Coding Conventions, I'll @-mention the appropriate NI engineers.
@alejandro5042
@DavidCurtiss
@irwand
@jryckman
@kcuzner
@mshafer-NI
@neilvana
@nethrasuresh
@pakdev
@rtzoeller
@sbethur
@stick152
@tkrebes
@Adithyak1998
@innagarc
@ShibaniRout

irwand
irwand approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@irwand irwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnarus : You're just adding to the documentation about BLK100 issue, not "fix" it. Please change the PR description. Thx!

@mnarus mnarus changed the title Fix BLK100 issue, add Visual Studio dir to .gitignore Adding documentation about BLK100 issue in D.1.12, add Visual Studio dir to .gitignore Mar 28, 2023
@mnarus mnarus marked this pull request as ready for review March 28, 2023 18:03
@mnarus mnarus closed this Mar 30, 2023
@mnarus mnarus reopened this Mar 30, 2023
@github-actions
Copy link
Contributor

Thank you for contributing! 👋

@github-actions
Copy link
Contributor

Thank you for contributing! 👋

Since this changes the Coding Conventions, I'll @-mention the appropriate NI engineers.
@alejandro5042
@DavidCurtiss
@irwand
@jryckman
@kcuzner
@mshafer-NI
@neilvana
@nethrasuresh
@pakdev
@rtzoeller
@sbethur
@stick152
@tkrebes
@Adithyak1998
@innagarc
@ShibaniRout

@mshafer-NI mshafer-NI merged commit fb6bc72 into ni:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irwand irwand irwand approved these changes

@mshafer-NI mshafer-NI mshafer-NI approved these changes

@neilvana neilvana Awaiting requested review from neilvana neilvana is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnarus @irwand @mshafer-NI