Skip to content

Remove D.1.12 from Coding-Conventions, bump black min version to 23.1 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 31, 2023
Merged

Remove D.1.12 from Coding-Conventions, bump black min version to 23.1 #119

merged 5 commits into from
Mar 31, 2023

Conversation

@mnarus
Copy link
Contributor

@mnarus mnarus commented Mar 30, 2023 •
edited
Loading

  • PWG decided to remove D.1.12 (DO NOT Put a blank line before a docstring ) from documentation in favor of black handling this now in black 23.1.
  • Bumped ni-python-styleguide black min version to 23.1
  • Ran poetry lock

Michelle Narus added 3 commits March 27, 2023 16:21
@github-actions
Copy link
Contributor

Thank you for contributing! 👋

@github-actions
Copy link
Contributor

Thank you for contributing! 👋

Since this changes the Coding Conventions, I'll @-mention the appropriate NI engineers.
@alejandro5042
@DavidCurtiss
@irwand
@jryckman
@kcuzner
@mshafer-NI
@neilvana
@nethrasuresh
@pakdev
@rtzoeller
@sbethur
@stick152
@tkrebes
@Adithyak1998
@innagarc
@ShibaniRout

@mnarus mnarus changed the title Remove D.1.12 from Coding-Conventions and bump black min version to 23.1 Remove D.1.12 from Coding-Conventions, bump black min version to 23.1 Mar 30, 2023
@mnarus mnarus marked this pull request as ready for review March 30, 2023 18:56
@mnarus mnarus requested review from irwand and neilvana as code owners March 30, 2023 18:56
@irwand irwand merged commit 7a29d4a into ni:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irwand irwand irwand approved these changes

@mshafer-NI mshafer-NI mshafer-NI approved these changes

@neilvana neilvana Awaiting requested review from neilvana neilvana is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnarus @irwand @mshafer-NI