Add support for Python 3.12 #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With pycodestyle 2.11, comparing types with `is` is no longer an error: PyCQA/pycodestyle#1084
pycodestyle 2.11 no longer reports E741 - ambiguous variable name for `if l == True` because it doesn't contain an assignment. PyCQA/pycodestyle#1118
|
Thank you for contributing! 👋 |
|
Thank you for contributing! 👋 Since this changes the Coding Conventions, I'll @-mention the appropriate NI engineers. |
mshafer-NI
approved these changes
Oct 5, 2023
bkeryan
commented
Oct 5, 2023
The "conventions change" is just updating an example to something will be flagged with changes to pycodestyle. No effective change. |
irwand
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update version constraints to use
flake8 = "^6.1"andpycodestyle = "^2.11"for Python 3.12 and later. The enhanced f-string support in Python 3.12 changed how theastmodule parses f-strings, which required updates topycodestyle.Fix test failures introduced by the update:
flake8no longer tolerates inline comments in theignorefield. Comments and error numbers must be on separate lines.pycodestyleno longer reports "E721 do not compare types, use 'isinstance()'" for comparisons that use theisoperator.pycodestyleno longer reports "E741 ambiguous variable name" when using the variable; it only reports this error when assigning the variable.Update PR workflow to test with Python 3.12.
Why should this Pull Request be merged?
Fixes #142
What testing has been done?
Ran
poetry run pytest -vwith both Python 3.9.13 and 3.12.0.