Add flake8-import-order #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this changes the Coding Conventions, I'll @-mention the appropriate NI engineers. @alejandro5042 |
DavidCurtiss
approved these changes
Feb 5, 2021
mshafer-NI
approved these changes
Feb 5, 2021
tests/test_cli/acknowledge_existing_errors_test_cases__snapshots/import_line_tests/output.py
Show resolved
Hide resolved
irwand
approved these changes
Feb 5, 2021
kcuzner
approved these changes
Feb 5, 2021
added 2 commits
February 5, 2021 15:41
rtzoeller
approved these changes
Feb 9, 2021
sbethur
approved these changes
Feb 9, 2021
rick-morrow
approved these changes
Feb 9, 2021
neilvana
approved these changes
Feb 10, 2021
pakdev
approved these changes
Feb 11, 2021
alexweav
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flake8-import order to ensure imports are grouped and listed alphabetically.
Users can configure the application's import name in the
pyproject.tomlfile, however we'll default to thepoetry-specified name for convenience.NOTE: We are using Google-style import ordering (not necessarily the full import style). Example is here. TL;DR all the third-party imports are in one-blob together, not in their own little huts.