treat global mutables as global vars #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irwand
approved these changes
Nov 17, 2021
|
comment job is broken... Since this changes the Coding Conventions, I'll @-mention the appropriate NI engineers. @alejandro5042 @alexweav @DavidCurtiss @irwand @jryckman @kcuzner @mshafer-NI @neilvana @nethrasuresh |
DavidCurtiss
approved these changes
Nov 17, 2021
rtzoeller
approved these changes
Jan 21, 2022
|
Is this a common convention for python? In rust mutable |
rick-morrow
approved these changes
Jan 21, 2022
mshafer-NI
commented
Jan 21, 2022
kcuzner
approved these changes
Jan 21, 2022
neilvana
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clarification that if a global is mutable, to treat is as a global var (snake_case) as opposed to a "constant reference" (SCREAMING_CASE)