Skip to content

Add fix command #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 79 commits into from
May 2, 2022
Merged

Add fix command #80

merged 79 commits into from
May 2, 2022

Conversation

@mshafer-NI
Copy link
Collaborator

Create "ni-python-styleguide fix" command to:

  • sort imports (uses isort, but then splits imports to one per line)
  • format with black
  • if --aggressive is passed, remove suppressions, first, then re-acknowledge anything remaining.

mshafer-NI
mshafer-NI commented Apr 1, 2022
View reviewed changes
mshafer-NI
mshafer-NI commented Apr 1, 2022
View reviewed changes
mshafer-NI
mshafer-NI commented Apr 1, 2022
View reviewed changes
irwand
irwand reviewed Apr 4, 2022
View reviewed changes
@mshafer-NI mshafer-NI marked this pull request as draft April 21, 2022 22:04
@mshafer-NI mshafer-NI mentioned this pull request Apr 21, 2022
Merged
@mshafer-NI mshafer-NI marked this pull request as ready for review May 2, 2022 14:59
mshafer-NI
mshafer-NI commented May 2, 2022
View reviewed changes
@mshafer-NI mshafer-NI merged commit c6566a4 into ni:main May 2, 2022
@mshafer-NI mshafer-NI deleted the add_fix_command branch May 2, 2022 19:03
@mshafer-NI
Copy link
Collaborator Author

Included in v0.1.11 -> https://github.com/ni/python-styleguide/releases/tag/v0.1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irwand irwand irwand approved these changes

@neilvana neilvana Awaiting requested review from neilvana neilvana is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mshafer-NI @irwand