pin importlib-metadata for python 3.7 and under #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(also update development
poetry.lock)Why:
Modules started failing to run ni-python-styleguide with
It appears this is caused by a breaking change in the 5.0.0 release of
importlib-metadata. (removing a deprecated entry point) [source - reference]In our testing, this does not affect Python 3.8 or .9, so choosing to not pin it for those versions.
Testing:
Reproduced the error locally by installing latest
ni-python-styleguideand attempting to lint.Tested fix by using
pipto install from local copy (after applying pin topyproject.toml) and verified thatni-python-styleguidewas now able to run on the project.