Skip to content

Conversation

@bkeryan
Copy link
Contributor

@bkeryan bkeryan commented Dec 8, 2022

When black 22.10.0 was released, the initial macOS x86_64 wheels were actually arm64 wheels: psf/black#3312

Apparently this has been corrected, but some of our GitHub agents still have the original, incorrect wheels in their Poetry caches.

Disallow black 22.10.0 to ensure that clients of ni-python-styleguide don't run into this problem.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Thank you for contributing! 👋

@bkeryan
Copy link
Contributor Author

bkeryan commented Dec 8, 2022

Run actions/setup-python@v2
Version 3.6 was not found in the local cache
Error: Version 3.6 with arch x64 not found
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

@mshafer-NI
Copy link
Collaborator

mshafer-NI commented Dec 8, 2022

Run actions/setup-python@v2
Version 3.6 was not found in the local cache
Error: Version 3.6 with arch x64 not found
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

‾\_(ツ)_/‾, 3.6 has been eol for a while. I guess it's time to stop testing it here...

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Thank you for contributing! 👋

@rtzoeller
Copy link
Contributor

the initial macOS x86_64 wheels were actually amd64 wheels

Typo? I think it should be arm64 or aarch64.

@bkeryan
Copy link
Contributor Author

bkeryan commented Dec 8, 2022

the initial macOS x86_64 wheels were actually amd64 wheels

Typo? I think it should be arm64 or aarch64.

Yes, I meant arm64.

matrix:
os: [macos-latest, windows-latest, ubuntu-latest]
python-version: [3.6, 3.7, 3.8, 3.9]
python-version: [3.7, 3.8, 3.9]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should commit #96 first so that removing 3.6 here is no longer part of this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed that other one. Thx !!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Thank you for contributing! 👋

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Thank you for contributing! 👋

@irwand irwand merged commit ed6c46b into ni:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants