Bump flake8 #98
Merged
Bump flake8 #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing! 👋 |
irwand
approved these changes
Jan 9, 2023
mshafer-NI
force-pushed
the
bump_flake8
branch
from
8efc5fc to
608978b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flake8 4.0 broke our io capture, so we opted to pin it; however, latest releases of pep8-naming (one of our plugins) require at least flake8 5.0 for compatibility.
This PR bumps flake8 to 5.x and addresses our capture so our tooling still works (including "fix") by using a io.TextIOWrapper backed by a io.BytesIO for the buffer that flake8 wants.
Note: between flake8 3.x and 5.x, it appears that the default sorting of errors for a given line has changed. To stabilize our tests, I opted to add an alphabetic sort of the error lines in such that our acknowledgements will be in a deterministic ordering.