Skip to content

Enhance error handling in start.py #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Enhance error handling in start.py #61

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ce3d5e
Enhance error handling in start.py
openhands-agent Dec 15, 2024
9266652
Change error to critical when bot can't start
openhands-agent Dec 15, 2024
a5e4ec1
:art: Add noqa for blind exception handling
openhands-agent Dec 15, 2024
022ee86
:goal_net: Make tracebacks only show in debug level
Paillat-dev Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ async def start_bot(bot: custom.Bot, token: str) -> None:
except LoginFailure as e:
logger.critical("Failed to log in, is the bot token valid?")
logger.debug("", exc_info=e)
except Exception as e: # noqa: BLE001
logger.critical("An unexpected error occurred while starting the bot.")
logger.debug("", exc_info=e)


async def start_backend(app: Quart, bot: discord.Bot, token: str) -> None:
Expand Down Expand Up @@ -64,9 +67,13 @@ def __init__(
app_config.logger_class = CustomLogger
app_config.include_server_header = False # security
app_config.bind = ["0.0.0.0:5000"]
await bot.login(token)
await serve(app, app_config)
patch("hypercorn.error")
try:
await bot.login(token)
await serve(app, app_config)
patch("hypercorn.error")
except Exception as e: # noqa: BLE001
logger.critical("An error occurred while starting the backend server.")
logger.debug("", exc_info=e)


def load_extensions() -> (
Expand Down Expand Up @@ -94,7 +101,12 @@ def load_extensions() -> (
continue

its_config = config["extensions"].get(name, config["extensions"].get(name.replace("_", "-"), {}))
module: ModuleType = importlib.import_module(f"src.extensions.{name}")
try:
module: ModuleType = importlib.import_module(f"src.extensions.{name}")
except ImportError as e:
logger.error(f"Failed to import extension {name}")
logger.debug("", exc_info=e)
continue
if not its_config:
its_config = module.default
config["extensions"][name] = its_config
Expand Down
Loading