Code cleanup #7
Open
Code cleanup #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dangling Javadoc comment
Reducing requirements on map type since code is calling toString anyway
Mainly so that they look different to IDEA. Multiple sequential statements show up as duplicated code. Two immutable lists with different contents don't. There's probably a way to share the common part of the lists still. Perhaps a private method could create a builder which builds the list with the first three parameters, and then the method appends the last two and builds the list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple independent commits for various warning fixes.
Viewing each in isolation may be easier but I'd recommend squashing the commits when merging.