fix: Prevent the active environment to be set up in the start script of the package.json. Replace that with the now.json's env.active property or default to 'default'

Author: nicolasdao

src/index.js

@@ -9,7 +9,7 @@ const fs = require('fs')
 const shortid = require('shortid')
 const path = require('path')
 const { getRouteDetails, matchRoute } = require('./routing')
-const { reqUtil, pkgJson } = require('./utils')
+const { reqUtil } = require('./utils')
 require('colors')
 
 /*eslint-disable */
@@ -61,16 +61,11 @@ let _allowedMethods = getAllowedMethods(_config) // Object
 let _preEvent = () => Promise.resolve(null)
 let _postEvent = () => Promise.resolve(null)
 
-// This guarentees that any environment variables defined in the package.json's start scripts get assigned even 
-// if the package.json's start script is not executed (which is the case with FaaS like Google Cloud Functions 
-// or AWS Lambda)
-pkgJson.initStartVariables()
-
 //////////////////////// 							END - INITIALIZE APP 							  ////////////////////////
 //////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
 //////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
 
-const getEnvName = () => ((_config || {}).env || {}).active || getProcessEnv().WEBFUNC_ENV || 'default'
+const getEnvName = () => ((_config || {}).env || {}).active || 'default'
 const getEnv = () => ((_config || {}).env || {})[getEnvName()] || {}
 const getHostingType = () => getEnv().hostingType || 'localhost'
 

src/utils.js

@@ -95,37 +95,8 @@ const getParams = req => {
 	})
 }
 
-const initStartVariables = () => {
-	try {
-		const pkg = require(cwdPath('package.json')) || {}
-		if (pkg.scripts && pkg.scripts.start) 
-			(pkg.scripts.start.trim()).split(' ')
-				.filter(x => x)
-				.map(x => x.split('='))
-				.filter(x => x.length == 2)
-				.forEach(x => { 
-					/*eslint-disable */
-					if (x[0] != 'NODE_ENV')
-						process.env[x[0]] = x[1]
-					else
-						process.env.WEBFUNC_ENV = x[1]						
-					/*eslint-enable */
-				})
-		/*eslint-disable */
-		if (!process.env.WEBFUNC_ENV && process.env.NODE_ENV)
-			process.env.WEBFUNC_ENV = process.env.NODE_ENV
-		/*eslint-enable */
-	}
-	catch(err) {
-		console.error(err.message)
-	}
-}
-
 module.exports = {
 	reqUtil: {
 		getParams
-	},
-	pkgJson: {
-		initStartVariables
 	}
 }