Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputSerializers (BERT/Networks) -- __init__ should not depend on data-related information [ARElight backlog] #313

Closed
nicolay-r opened this issue Apr 4, 2022 · 2 comments
Closed

InputSerializers (BERT/Networks) -- __init__ should not depend on data-related information [ARElight backlog] #313

nicolay-r opened this issue Apr 4, 2022 · 2 comments
Assignees
@nicolay-r
Labels
critical limitation

Comments

@nicolay-r
Copy link
Owner

Affects:
BertExperimentInputSerializerIterationHandler
NetworksInputSerializerExperimentIteration
NetworksTrainingIterationHandler

Because all of these classes requires data-related information at __init__.
@nicolay-r nicolay-r self-assigned this Apr 4, 2022
@nicolay-r
Copy link
Owner Author

nicolay-r/AREnets#6 -- same concepts, and related to that issue due to the latter

@nicolay-r nicolay-r changed the title InputSerializers (BERT/Networks) -- __init__ requires data-related information [ARElight backlog] InputSerializers (BERT/Networks) -- __init__ should not depend on data-related information [ARElight backlog] Apr 4, 2022
@nicolay-r nicolay-r mentioned this issue May 6, 2022
Closed
2 tasks
@nicolay-r nicolay-r mentioned this issue May 31, 2022
Closed
nicolay-r added a commit that referenced this issue May 31, 2022
@nicolay-r
related to #318 , affects #313 , fixed #322
fbedd61
@nicolay-r
Copy link
Owner Author

Proceeded in a form of the #365 issue (see refactoring details out there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical limitation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r