Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BertExperimentInputSerializerIterationHandler -- Simplify API [Blog example backlog] #318

Closed
2 tasks done
nicolay-r opened this issue May 6, 2022 · 2 comments
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented May 6, 2022

It goes from the following post: https://nicolay-r.github.io/blog/articles/2022-05/process-mass-media-relations-with-arekit

  • annot labels formatter might be removed in further.
  • Switch from Hander to PipelineItems (the latter allows to pass parameters via contexts)

class BertExperimentInputSerializerIterationHandler(ExperimentIterationHandler):
def __init__(self, exp_io, exp_ctx, doc_ops, opin_ops,
sample_labels_fmt, annot_labels_fmt, value_to_group_id_func,
sample_provider_type, entity_formatter, balance_train_samples):
assert(isinstance(exp_io, BaseIOUtils))
assert(isinstance(doc_ops, DocumentOperations))
assert(isinstance(opin_ops, OpinionOperations))
assert(isinstance(sample_labels_fmt, StringLabelsFormatter))
assert(isinstance(annot_labels_fmt, StringLabelsFormatter))
assert(callable(value_to_group_id_func))
super(BertExperimentInputSerializerIterationHandler, self).__init__()

Considering the following changes while using AREkit API from the outside (ARElight project):
image

@nicolay-r nicolay-r added the enhancement New feature or request label May 6, 2022
@nicolay-r nicolay-r self-assigned this May 6, 2022
@nicolay-r nicolay-r changed the title BertExperimentInputSerializerIterationHandler -- [Blog example backlog] BertExperimentInputSerializerIterationHandler -- Simplify API [Blog example backlog] May 6, 2022
@nicolay-r
Copy link
Owner Author

#313 related refactoring.

nicolay-r added a commit that referenced this issue May 31, 2022
@nicolay-r nicolay-r changed the title BertExperimentInputSerializerIterationHandler -- Simplify API [Blog example backlog] BertExperimentInputSerializerIterationHandler -- Simplify API [Blog example backlog] Jun 4, 2022
@nicolay-r
Copy link
Owner Author

#365 covers and proceeds this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant