Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExperimentIterationHandler -- switch to the PipelineItem for NN and BERT serialization [Remove ExperimentEngine and ExperimentHandler] #365

Closed
7 tasks done
nicolay-r opened this issue Jul 12, 2022 · 0 comments
Closed
7 tasks done

ExperimentIterationHandler -- switch to the PipelineItem for NN and BERT serialization [Remove ExperimentEngine and ExperimentHandler] #365

nicolay-r opened this issue Jul 12, 2022 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jul 12, 2022 •
edited
Loading

Reason: it allows us to adopt a single data-serialization pipeline, which may involve a variaty of PipelineItems.

Reason2: demarcate data from nn/BERT serialization setups.

  • Remove DataFolding from exp_ctx (as a result, since DataFolding is not a part of the model setups)
  • Remove ExperimentIterationHandler
  • Remove Experiment Engine
  • EvalIterationHandler to PipelineItem
  • BaseOutputConverterIterationHandler to PipelineItem
  • Perform refactoring as illustrated at the images below
  • Move data_folding and data_pipelines into pipeline context

bert_serialization_refactoring
nn_serialization_pipeline_upd
@nicolay-r nicolay-r added the enhancement New feature or request label Jul 12, 2022
@nicolay-r nicolay-r self-assigned this Jul 12, 2022
@nicolay-r nicolay-r changed the title ExperimentIterationHandler -- switch to the PipelineItem for NN and BERT serialization ExperimentIterationHandler -- switch to the PipelineItem for NN and BERT serialization ... and others Jul 14, 2022
@nicolay-r nicolay-r changed the title ExperimentIterationHandler -- switch to the PipelineItem for NN and BERT serialization ... and others ExperimentIterationHandler -- switch to the PipelineItem for NN and BERT serialization [Remove ExperimentEngine and ExperimentHandler] Jul 14, 2022
@nicolay-r nicolay-r changed the title ExperimentIterationHandler -- switch to the PipelineItem for NN and BERT serialization [Remove ExperimentEngine and ExperimentHandler] ExperimentIterationHandler -- switch to the PipelineItem for NN and BERT serialization [Remove ExperimentEngine and ExperimentHandler] Jul 14, 2022
nicolay-r added a commit that referenced this issue Jul 14, 2022
@nicolay-r
#365 related for bert. Switched to PipelineItem
cc27754
nicolay-r added a commit that referenced this issue Jul 14, 2022
@nicolay-r
#365 related. Updated for neural networks and BERT.
6d415df
nicolay-r added a commit that referenced this issue Jul 14, 2022
@nicolay-r
#365 related refactoring.
30849f4
nicolay-r added a commit that referenced this issue Jul 14, 2022
@nicolay-r
#365 refactoring.
b6ea01e
nicolay-r added a commit that referenced this issue Jul 14, 2022
@nicolay-r
#365 refactoring as illustated on images.
8457797
nicolay-r added a commit that referenced this issue Jul 14, 2022
@nicolay-r
Update comment (#365)
106fbfe
This was referenced Jul 14, 2022
Closed
Closed
nicolay-r added a commit that referenced this issue Jul 14, 2022
@nicolay-r
#365 related
2534f45
nicolay-r added a commit that referenced this issue Jul 14, 2022
@nicolay-r
Removed non utilized property (#365)
36ee200
nicolay-r added a commit that referenced this issue Jul 14, 2022
@nicolay-r
#365 related fix
38258de
nicolay-r added a commit that referenced this issue Jul 15, 2022
@nicolay-r
#320 affected. #365 related
57be889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r