Proxies are not visible in domains list

[Plytas]

Describe the bug
I'm trying out the dev build and I'm able to set up a proxy and it works. Strangely enough, I'm unable to see it in Domains list.

Here is log output:

==================================
PHP MONITOR by Nico Verbruggen
Version 5.3-dev (770)
==================================
[ARCH] The user is running PHP Monitor with the architecture: arm64
[OK] `/opt/homebrew/bin/brew` exists
[OK] `/opt/homebrew/bin/php` exists
[OK] `ls /opt/homebrew/opt | grep php` returned php result
[OK] `valet` binary exists
[W] PHP Monitor does not have permission to show notifications.
[E] PHP Monitor encounted an error determining notification permissions:
[E] Error Domain=UNErrorDomain Code=1 "Notifications are not allowed for this application" UserInfo={NSLocalizedDescription=Notifications are not allowed for this application}
[OK] `/private/etc/sudoers.d/brew` contains brew
[OK] `/private/etc/sudoers.d/valet` contains valet
[OK] `sudo /opt/homebrew/bin/brew services info` JSON loaded
[OK] `config.json` was valid
[OK] `valet --version` was loaded
==================================
PHP Monitor has determined the application has successfully passed all checks.
PHP Monitor has extracted the version number of Valet: 3.1.6
This version of Valet supports isolation.
Valet version 3.1.6 is recent enough, OK (recommended: 2.16.2)
When on your system, the `php` formula means version 8.1!
The PHP versions that were detected are: ["7.4", "8.0", "8.1"]
The user does not appear to have tapped: shivammathur/php
Determining broken PHP-FPM...
Setting up watchers...
Detecting applications...
There was no .phpmon.conf.json file to be loaded.
No watcher currently active...
Detected applications: ["PhpStorm", "iTerm"]
No global hotkey was saved in preferences. None set.
Fewer than or 50 sites found, preloading list of sites...
PHP Monitor is ready to serve!
Awesome, the user has already seen the sponsor message.

To Reproduce
Steps to reproduce the behavior:

1. Have a proxy set up
2. Click on 'View Domains List...'
3. Proxy is not displayed

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
Don't want to show my domain list, but here you can see that there's no Proxies column as seen here.

Required information

• Did you consult the FAQ in the README? Yes
• Did you try "Fix My Valet"? No
• OS: macOS Monterey
• PHP Monitor version 5.3-dev (770)

Additional context
Note: I am using a non default TLD, could that be the cause?

[nicoverbruggen]

Hi @Plytas! Thanks for testing, I appreciate you taking the time to report this issue.

There isn't a proxies column in the DEV release, because the UI has changed. Instead, the proxy should just be listed (as "Proxy" under Project Type), like this:

If your proxy isn't showing up, could you share your nginx configuration file for the domain that you've proxied? Maybe there's an issue with my Nginx configuration parser...

You should be able to find the relevant config file in ~/.config/valet/Nginx/(insert-domain-name-here).

[Plytas]

Here is the nginx configuration file:

# valet stub: secure.proxy.valet.conf

server {
    listen 127.0.0.1:80;
    #listen 127.0.0.1:80; # valet loopback
    server_name live.whatagraph.dev.com www.live.whatagraph.dev.com *.live.whatagraph.dev.com;
    return 301 https://$host$request_uri;
}

server {
    listen 127.0.0.1:443 ssl http2;
    #listen 127.0.0.1:443 ssl http2; # valet loopback
    server_name live.whatagraph.dev.com www.live.whatagraph.dev.com *.live.whatagraph.dev.com;
    root /;
    charset utf-8;
    client_max_body_size 128M;
    http2_push_preload on;

    location /41c270e4-5535-4daa-b23e-c269744c2f45/ {
        internal;
        alias /;
        try_files $uri $uri/;
    }

    ssl_certificate "/Users/vytas/.config/valet/Certificates/live.whatagraph.dev.com.crt";
    ssl_certificate_key "/Users/vytas/.config/valet/Certificates/live.whatagraph.dev.com.key";

    access_log off;
    error_log "/Users/vytas/.config/valet/Log/live.whatagraph.dev.com-error.log";

    error_page 404 "/Users/vytas/.composer/vendor/laravel/valet/server.php";

    location / {
        proxy_pass http://localhost:8080/;
        proxy_set_header   Host              $host;
        proxy_set_header   X-Real-IP         $remote_addr;
        proxy_set_header   X-Forwarded-For   $proxy_add_x_forwarded_for;
        proxy_set_header   X-Forwarded-Proto $scheme;
        proxy_set_header   X-Client-Verify   SUCCESS;
        proxy_set_header   X-Client-DN       $ssl_client_s_dn;
        proxy_set_header   X-SSL-Subject     $ssl_client_s_dn;
        proxy_set_header   X-SSL-Issuer      $ssl_client_i_dn;
        proxy_set_header   X-NginX-Proxy true;
        proxy_set_header   Upgrade $http_upgrade;
        proxy_set_header   Connection "upgrade";
        proxy_http_version 1.1;
        proxy_read_timeout 1800;
        proxy_connect_timeout 1800;
        chunked_transfer_encoding on;
        proxy_redirect off;
        proxy_buffering off;
    }

    location ~ /\.ht {
        deny all;
    }
}

This domain does appear in valet proxies command.

[nicoverbruggen]

Okay, thanks for the info.

I've determined that there is indeed an issue with regex I'm using. I'll fix this later and I'll make a new build for you, so you can confirm that this is fixed. Thanks again!

[nicoverbruggen]

The offending line in question was this:

proxy_pass http://localhost:8080/;

The regular expression I set up didn't handle the trailing slash (/) before the semicolon. This is now fixed!

Yesterday, I also added some extra validation in the "create proxy" GUI which will make it impossible to enter what PHP Monitor considers an invalid proxy subject. (It is still possible to create a proxy with Valet's CLI that won't be detected by PHP Monitor, but I don't expect that will be an issue for most people.)

Please try out this build and let me know if it now works on your system: phpmon-prerelease-3.zip

[Plytas]

Can confirm proxy now appears in the new build