Increases default expires/max-age to 24h #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to close niiknow#11. Also, changing default cache duration to 24h (instead of 12h).
Author
|
This actually only augments the max age to 24h instead of 12h. Having 2 Cache-Control headers is not an actual issue. |
demetriusnunes
changed the title
add_header after expires
Contributor
|
My cache control header is there just in case somebody want to host it publicly. Since the cache set to "public" / client-side. It really doesn't matter to anyone who is hosting it behind a proxy like me. I override that cache-control on my CDN anyway. Approve merging per request. |
noogen
added a commit
that referenced
this pull request
Mar 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to close #11. Also, changing default cache duration to 24h (instead of 12h).