Add support for DISTINCT ON #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves nilenso#31 This uses the new multimethod added to honeysql in seancorfield/honeysql@509df19 to add DISTINCT ON support. Tests are included which cover the behavior. This commit updates deps.edn to point to the github repo for honeysql which will obviously have to be changed once honeysql is released.
Closed
a release was made which includes the necessary multimethod for the new distinct-on functionality to work.
Contributor
Author
|
@ukriish I got this pull request back in shape now that the necessary multimethod in honeysql has been released. |
|
any reason this has not been merged ? |
Contributor
|
Apologies for the delay. Merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31
This uses the new multimethod added to honeysql in
seancorfield/honeysql@509df19
to add DISTINCT ON support.
Tests are included which cover the behavior.
This commit updates deps.edn to point to the github repo for honeysql
which will obviously have to be changed once honeysql is released.