Add create / drop extension #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @kwrooijen, thanks for the PR! Give me a day or so to go through this. |
scimetfoo
reviewed
Feb 12, 2021
Contributor
scimetfoo
left a comment
scimetfoo
left a comment
There was a problem hiding this comment.
Looks good to me. Could you please add these to the index in the readme along with the examples?
scimetfoo
reviewed
Feb 12, 2021
README.md
Outdated
| `create-extension` can be used to create extensions with a given keyword. | ||
| ```clj | ||
| (-> (create-extension :uuid-ossp :if-not-exists? true) | ||
| (sql/format :allow-dashed-names? true |
Contributor
There was a problem hiding this comment.
Could you fix the formatting here please? Sorry for nitpicking.
Contributor
Author
There was a problem hiding this comment.
Whoops! my mistake
scimetfoo
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the create / drop extension statements which seem to be missing.
https://www.postgresql.org/docs/9.1/sql-createextension.html
https://www.postgresql.org/docs/9.1/sql-dropextension.html