Fix getDERfromPEM in Ubuntu 22.04 #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get a wrong hash in Ubuntu 22.04. I suspect that the regular expression of awk in `getDERfromPEM` caused this problem. Without the [\r|\n]*, awk will never set i=1. As a result, the awk will output an empty string, the downstream functions will process an empty string and finally output a wrong hash (of course the hash of an empty string is not the hash of the certificate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get a wrong hash in Ubuntu 22.04. I suspect that the regular expression of awk in
getDERfromPEMcaused this problem.Without the
[\r|\n]*, awk will never set i=1. As a result, awk will always output an empty string, the downstream functions will process an empty string and finally output a wrong hash (of course the hash of an empty string is not the hash of the certificate).I don't know whether #17 is related to
getDERfromPEMand I hope this commit can fix it.