-
Notifications
You must be signed in to change notification settings - Fork 308
ENH: Add RMS framewise displacement following Jenkinson et al. (2002) #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ng Jenkinson (2002)
… Jenkinson (2002)
|
Thank your for raising your pull request. Some of the fMRIPRep maintainers will review your changes as soon as time permits. PR ReviewPlease check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
Please check what applies in the following aspects of the PR: Code documentation
Documentation site
Tests
Data
Dependencies: smriprep
Dependencies: niworkflows
Dependencies: sdcflows
Dependencies: Nipype
Dependencies: other
Reports generated within CI tests
|
oesteban
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
oesteban
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few new nitpicks
|
@mgxd anything jumping out into your eye? |
mgxd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
Changes proposed in this pull request
fsl_motion_outliersto confounds file. #1970 .fsl_motion_outliers, we directly usemcflirtto estimate the root mean square displacement. We keep the Power FD computed as before. This is more efficient, results in a cleaner workflow, and allows us to use the same reference that we use for computing the realignment parameters.rmsdfollowing the BIDS derivatives specification.Future work should consider adding the option to flag outliers on the basis of RMS (Jenkinson) FD.
Documentation that should be reviewed