Skip to content

Conversation

@oesteban
Copy link
Member

No description provided.

@oesteban oesteban requested a review from eilidhmacnicol April 30, 2020 16:45
@pull-assistant
Copy link

pull-assistant bot commented Apr 30, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ENH: Add AFNI to docker image

Powered by Pull Assistant. Last update b836692 ... b836692. Read the comment docs.

bzip2 \
ca-certificates \
xvfb \
cython3 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking that cython3 is no longer needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't needed since the beginning - sorry about that.

ENV PATH=$ANTSPATH/bin:$PATH

# Pre-cache neurodebian key
COPY docker/files/neurodebian.gpg /usr/local/etc/neurodebian.gpg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL what neurodebian was. Looks good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oesteban oesteban merged commit 2d97757 into master Apr 30, 2020
@oesteban oesteban deleted the enh/docker-afni branch April 30, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants