Skip to content

Conversation

chrisgorgo
Copy link
Member

I have refactored (fixed) the ROIstat interface. I opted for list output instead of writing values to a file, but I'm open for discussion.

@chrisgorgo chrisgorgo mentioned this pull request Nov 5, 2013
@bpinsard
Copy link
Contributor

bpinsard commented Nov 5, 2013

ok, maybe the option to output to a file would be useful,
I just ran into another problem, the output is cut if I ask for too many measures on too many ROIS from 3dROIstats, it seems that the length of stdout in nipype is limited to 20480, what could be the reason?

@satra
Copy link
Member

satra commented Nov 5, 2013

this might come from limitations of capturing streaming output. i think in such cases where the output of the interface is from stdout, one should overwrite terminal_output to specifically be 'allatonce'. to make it clear to others that this interface is overriding the default setting, this should be done at the inputspec level.

    terminal_output = traits.Enum('allatonce', 
                                  desc=('Control terminal output: 
                                        '`allatonce` - waits till command is '
                                        'finished to display output'),
                                  nohash=True, mandatory=True, usedefault=True)

@pankajsingh88
Copy link

I want to echo bpinsard. An option to output to a file would be very useful.

@chrisgorgo
Copy link
Member Author

I would prefer a more general solution for saving values to a file. I'm thinking along the lines of datasink creating json files when values instead of file paths are passed to it.

@chrisgorgo
Copy link
Member Author

I reverted to saving everything to a file. @pankajsingh88 is this is what you had in mind?

chrisgorgo added a commit that referenced this pull request Dec 20, 2013
@chrisgorgo chrisgorgo merged commit d95296e into nipy:master Dec 20, 2013
@chrisgorgo chrisgorgo deleted the fix/afni_stats branch December 20, 2013 12:53
@chrisgorgo chrisgorgo restored the fix/afni_stats branch January 8, 2014 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants