3dROIstats #713
Closed
3dROIstats #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #712. The main difference is that I opted for values instead of files, but I'm open to discussion. |
added 2 commits
November 5, 2013 12:10
* master: fix: cleaned up file removal to pay attention to related files such as img/hdr/mat, BRIK/HEAD
|
@chrisfilo and @bpinsard , any update on which of the PRs should be merged. can you guys figure it out soon? |
|
Quite a few changes got into this PR. Could you check if all ROIstat related fixes are satisfied with #712 and cherry pick other changes and send a new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3dROIstat was not working with all options, outputs some weird json file and does not have common out_file and output_filetype options.