allow taking in nifti file rather than filename #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks great - although I think we should now change the argument /e but I can take that on- just need a little while! |
Contributor
Author
|
sure, feel free to push more commits to this PR. |
Contributor
Author
|
@janfreyberg Do you think you will have to get to this? Otherwise I can take a stab at finishing up PR. |
Contributor
|
sorry - I've been a bit busy lately so haven't had much time to look after this project. I can just merge this and then make the improvements later - I think that's probably the easiest way to go about it. |
Contributor
Author
|
sure, sounds good. I would merge: #17 first and then I can rebase this |
Contributor
|
Done! |
cancan101
force-pushed
the
handle_file
branch
from
dc0aff1 to
c0e33e4
Compare
Contributor
Author
|
rebased |
Contributor
|
Excellent, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #17
closes #12