Skip to content

Conversation

djarecka
Copy link
Collaborator

@djarecka djarecka commented Jan 31, 2020

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

  • adding CONTRIBUTING.md
  • adding zenodo file

I've created manually a first zenodo file (I haven't uploaded anything to zenodo, just the file for now), please check your info.
(@satra - I assumed that you want me the last; @mgxd - I've changed your affiliation to Stanford, in Nipype you still have MIT; @kaczmarj - I left MIT)

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #193 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files          17       17           
  Lines        2758     2752    -6     
  Branches      729      726    -3     
=======================================
- Hits         2381     2376    -5     
+ Misses        243      241    -2     
- Partials      134      135    +1     
Flag Coverage Δ
#unittests 83.61% <ø> (-2.72%) ⬇️
Impacted Files Coverage Δ
pydra/engine/workers.py 84.00% <0.00%> (ø) ⬆️
pydra/engine/submitter.py 91.34% <0.00%> (ø) ⬆️
pydra/__init__.py 68.75% <0.00%> (ø) ⬆️
pydra/engine/helpers.py 85.79% <0.00%> (ø) ⬆️
pydra/engine/specs.py 91.63% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071ad96...08bbe90. Read the comment docs.

@djarecka djarecka changed the title adding contribution instructions adding contribution instructions (closes #89) Jan 31, 2020
Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - I've updated Chris's and my affiliations, and some missed Pydra substitutions

djarecka and others added 6 commits February 3, 2020 10:35
Co-Authored-By: Satrajit Ghosh <satrajit.ghosh@gmail.com>
Co-Authored-By: Mathias Goncalves <goncalves.mathias@gmail.com>
Co-Authored-By: Mathias Goncalves <goncalves.mathias@gmail.com>
Co-Authored-By: Mathias Goncalves <goncalves.mathias@gmail.com>
Co-Authored-By: Mathias Goncalves <goncalves.mathias@gmail.com>
Co-Authored-By: Mathias Goncalves <goncalves.mathias@gmail.com>
@djarecka djarecka merged commit f892ce0 into nipype:master Feb 3, 2020
@djarecka djarecka deleted the doc/contr branch December 30, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants