Skip to content

fix: pin browser #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix: pin browser #447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d17218e
fix: pin browser
Feb 18, 2025
dfff9df
fix: pin browser
Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ def pytest_runtest_setup(item: Item) -> None:
},
)
chrome_options.enable_bidi = True
# https://forum.robotframework.org/t/maximize-window-chromedriver-133/8416/3
chrome_options.browser_version = "132"
chrome_options.add_argument("disable-dev-shm-usage")
chrome_options.add_argument("no-sandbox")
chrome_options.add_argument("allow-file-access-from-files")
Expand Down Expand Up @@ -192,7 +194,7 @@ def pytest_runtest_setup(item: Item) -> None:
case "remote":
chrome_options = webdriver.ChromeOptions()
# https://aerokube.com/images/latest/#_chrome
chrome_options.browser_version = "127.0"
chrome_options.browser_version = "128.0"
Comment on lines 196 to +197
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider using dynamic version for remote browser.

Similar to the local browser version, the remote browser version is hardcoded to "128.0".

-# https://aerokube.com/images/latest/#_chrome
-chrome_options.browser_version = "128.0"
+# Use environment variable to allow flexible version configuration
+chrome_options.browser_version = os.getenv("REMOTE_CHROME_VERSION", "latest")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# https://aerokube.com/images/latest/#_chrome
chrome_options.browser_version = "127.0"
chrome_options.browser_version = "128.0"
# Use environment variable to allow flexible version configuration
chrome_options.browser_version = os.getenv("REMOTE_CHROME_VERSION", "latest")

chrome_options.set_capability(
"selenoid:options",
{
Expand Down
Loading