Skip to content

Conversation

@eavam
Copy link
Contributor

@eavam eavam commented Jun 23, 2020

Add commit type "chore". It needed for editing scripts or other not production files.

@nitayneeman
Copy link
Owner

nitayneeman commented Jul 6, 2020

Hey @eavam,
Thanks for your PR!

The "chore" type was removed on purpose, and actually was replaced with "build", in order to be aligned with the Angular commit message conventions.

But you can always customize your types 🙂

@eavam
Copy link
Contributor Author

eavam commented Jul 7, 2020

Hey @eavam,
Thanks for your PR!

The "chore" type was removed on purpose, and actually was replaced with "build", in order to be aligned with the Angular commit message conventions.

But you can always customize your types 🙂

Wow, thanks :) Maybe it's worth adding a link then, so that it is clear why these messages are selected?
I can add if necessary :)

@nitayneeman
Copy link
Owner

Hey @eavam,
Thanks for your PR!
The "chore" type was removed on purpose, and actually was replaced with "build", in order to be aligned with the Angular commit message conventions.
But you can always customize your types 🙂

Wow, thanks :) Maybe it's worth adding a link then, so that it is clear why these messages are selected?
I can add if necessary :)

Great idea - I think we can also add a short sentence under the preview image that mentions it, like:
"Notice that the default types are aligned with the Angular commit message conventions."

And, the word "conventions" will link to them.

Go for it if you can :)

@eavam
Copy link
Contributor Author

eavam commented Jul 9, 2020

I'm added message in #16 😁

@nitayneeman nitayneeman merged commit eb68d3d into nitayneeman:master Jul 11, 2020
nitayneeman added a commit that referenced this pull request Jul 11, 2020
nitayneeman added a commit that referenced this pull request Jul 11, 2020
@nitayneeman
Copy link
Owner

I'm added message in #16 😁

LOL, I missed out your recent comment and merged this PR by mistake (but reverted it) 😅

Anyway, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants