Skip to content

Added a dark theme to the style.css#215

Closed
JaidenW wants to merge 5 commits intolldap:mainfrom
JaidenW:main
Closed

Added a dark theme to the style.css#215
JaidenW wants to merge 5 commits intolldap:mainfrom
JaidenW:main

Conversation

@JaidenW
Copy link
Copy Markdown
Contributor

@JaidenW JaidenW commented Jul 3, 2022

No description provided.

JaidenW and others added 4 commits April 24, 2022 19:34
Help document for configuring LDAP backend on Organizr
No more eye searing at night!
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 3, 2022

Codecov Report

Merging #215 (970e986) into main (5420dcf) will increase coverage by 9.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   34.18%   43.61%   +9.43%     
==========================================
  Files          52       52              
  Lines        7822     9927    +2105     
==========================================
+ Hits         2674     4330    +1656     
- Misses       5148     5597     +449     
Impacted Files Coverage Δ
server/src/domain/sql_tables.rs 91.56% <0.00%> (-3.31%) ⬇️
server/src/main.rs 0.89% <0.00%> (-0.29%) ⬇️
app/src/infra/api.rs 0.00% <0.00%> (ø)
server/src/infra/cli.rs 0.00% <0.00%> (ø)
server/src/infra/mail.rs 0.00% <0.00%> (ø)
app/src/components/login.rs 0.00% <0.00%> (ø)
server/src/infra/logging.rs 0.00% <0.00%> (ø)
server/src/infra/db_cleaner.rs 0.00% <0.00%> (ø)
server/src/infra/tcp_server.rs 0.00% <0.00%> (ø)
server/src/infra/ldap_server.rs 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5420dcf...970e986. Read the comment docs.

oops. Missed some
@JaidenW
Copy link
Copy Markdown
Contributor Author

JaidenW commented Jul 3, 2022

<footer class="text-center text-muted fixed-bottom bg-light"> Should remain the same, i didn't realize that it was fixed and overlaps some elements, the bg-light tag is required, & handled via CSS override :)

Comment thread app/static/style.css

body.dark-theme{
background:#202020;
color:#fff!;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want pure white on pure black. If we take Material design's recommendations (not that it's gospel, but it's a good starting guideline) we'd have a background of #121212 for the very back, up to #242424 for the most accentuated background, and a text color of at most #dedede

@nitnelave
Copy link
Copy Markdown
Member

What would you think of something like https://vinorodrigues.github.io/bootstrap-dark/ ? Rather than creating/maintaining our own dark theme.

@JaidenW
Copy link
Copy Markdown
Contributor Author

JaidenW commented Jul 13, 2022

That might be better, especially if you intend to add anything else to it in the future, that would likely also likely make it easier for you to style things on your own -

One request i have, since i saw you talking about theming (more than just dark theme) add a stylesheet for custom CSS that users can edit, i've just tried editing the style.css directly and it was not having it. now i have this up and running though, i'd like to make my own theme for it.

@nitnelave
Copy link
Copy Markdown
Member

Closing in favor of #250

@nitnelave nitnelave closed this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants