Nextcloud.md updated & Added the tutorial for OIDC & Authelia#369
Nextcloud.md updated & Added the tutorial for OIDC & Authelia#369nitnelave merged 8 commits intolldap:mainfrom Normanras:nextcloud_docs
Conversation
|
Forgot to run cargo... closing this PR and resubmitting. |
|
no errors with cargo fmt |
nitnelave
left a comment
nitnelave
left a comment
There was a problem hiding this comment.
Sorry for the many comments, but it's a rather complicated setup, so I want to try to eliminate as much ambiguity as possible.
No problem at all! I would rather go through and get it right instead of having to go back to redo the work in a new PR. I'm not sure why there are so many backtick errors though, I made sure to preview everything locally and in my fork and it looked normal. Thanks for finding and commenting on them. |
|
Okay, I feel like we're going down a path here, but for this PR I've implemented all the requested changes and added some extra links and references (such as Authelia's client secret/id). I also removed over-explaining lines and added a section at the top detailing assumptions. I don't have time in the coming weeks, but I think revamping this with a bit more explanation of the Authelia setup might add some clarity. I'm open to your feedback, but let me know what you see in this commit. As I said, I'd rather it be right this time rather than go back after its merged. I'm mostly concerned that the backticks errors will persist, so I'll have to open it in another editor if it continues to revert to apostrophes. |
…users > nextcloud_users, clarity to certain sections.
nitnelave
left a comment
nitnelave
left a comment
There was a problem hiding this comment.
It looks good! Can you just remove the example_configs/images/.DS_Store file?
Yes, done. |
nitnelave
left a comment
nitnelave
left a comment
There was a problem hiding this comment.
Almost there! It should be the last round. Sorry I didn't catch these earlier.
|
Thanks a lot! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
=======================================
Coverage 68.60% 68.60%
=======================================
Files 32 32
Lines 6236 6236
=======================================
Hits 4278 4278
Misses 1958 1958 |
2 participants
Added Tutorial for Nextcloud/OIDC/Authelia/LLDAP & Updated minor changes on Nextcloud.md