Small fix to enable mysql schema creation#396
Closed
naturalethic wants to merge 1 commit intolldap:mainfrom
Closed
Small fix to enable mysql schema creation#396naturalethic wants to merge 1 commit intolldap:mainfrom
naturalethic wants to merge 1 commit intolldap:mainfrom
Conversation
nitnelave
approved these changes
Dec 16, 2022
Member
nitnelave
left a comment
nitnelave
left a comment
There was a problem hiding this comment.
The changes look good, but I'd like to test them with all of sqlite, mysql and postgresql before merging.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 67.99% 68.00%
=======================================
Files 39 39
Lines 6353 6354 +1
=======================================
+ Hits 4320 4321 +1
Misses 2033 2033 |
martadinata666
added a commit
to martadinata666/lldap
that referenced
this pull request
Jan 8, 2023
martadinata666
added a commit
to martadinata666/lldap
that referenced
this pull request
Jan 9, 2023
CI update
martadinata666
added a commit
to martadinata666/lldap
that referenced
this pull request
Jan 11, 2023
CI update
martadinata666
added a commit
to martadinata666/lldap
that referenced
this pull request
Jan 11, 2023
martadinata666
added a commit
to martadinata666/lldap
that referenced
this pull request
Jan 11, 2023
CI update
Member
|
Closing in favor of #418 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two small changes will fix this to work with mysql. I do not know if it breaks sqlite.