Skip to content

fix: Skip DNS resolution for host.docker.internal for linux #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix: Skip DNS resolution for host.docker.internal for linux #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d02886
workaround deno DNS resolution failure
tjholm Oct 22, 2024
a3e79fe
fmt
tjholm Oct 22, 2024
a2250e9
update comment
tjholm Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/project/batch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,9 @@ func (s *Batch) RunContainer(stop <-chan bool, updates chan<- ServiceRunUpdate,
if goruntime.GOOS == "linux" {
dockerHost := env.GetEnv("NITRIC_DOCKER_HOST", "172.17.0.1")

// FIXME: Skip dns resolution for now to allow nitric apps using deno to work on linux
// https://github.com/denoland/deno/issues/25927
runtimeOptions.nitricHost = dockerHost.String()
// setup host.docker.internal to route to host gateway
// to access rpc server hosted by local CLI run
hostConfig.ExtraHosts = []string{"host.docker.internal:" + dockerHost.String()}
Expand Down
3 changes: 3 additions & 0 deletions pkg/project/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,9 @@ func (s *Service) RunContainer(stop <-chan bool, updates chan<- ServiceRunUpdate
if goruntime.GOOS == "linux" {
dockerHost := env.GetEnv("NITRIC_DOCKER_HOST", "172.17.0.1")

// FIXME: Skip dns resolution for now to allow nitric apps using deno to work on linux
// https://github.com/denoland/deno/issues/25927
runtimeOptions.nitricHost = dockerHost.String()
// setup host.docker.internal to route to host gateway
// to access rpc server hosted by local CLI run
hostConfig.ExtraHosts = []string{"host.docker.internal:" + dockerHost.String()}
Expand Down
Loading