Another failing case, post #72 and #93

[cpotter1]

//  @Ignore // still broken as of 3.0.2 (even after #72 and #93 was fixed)
  @Test
  public void orderByOnNullableColumn3() {
    NitriteCollection coll = db.getCollection("orderByOnNullableColumn3");
    try {
      coll.createIndex("startTime", IndexOptions.indexOptions(IndexType.NonUnique));
    } catch (IndexingException e) {
      // ignore
    }

    coll.remove(Filters.ALL);

    Document doc = new Document().put("id", "test-1").put("group", "groupA");
    assertEquals(1, coll.insert(doc).getAffectedCount());
    System.out.println("doc1=" + doc);

    doc = new Document().put("id", "test-2").put("group", "groupA").put("startTime", DateTime.now());
    assertEquals(1, coll.insert(doc).getAffectedCount());
    System.out.println("doc2=" + doc);

    doc = new Document().put("id", "test-3").put("group", "groupA").put("startTime", DateTime.now().plusMinutes(1));
    assertEquals(1, coll.insert(doc).getAffectedCount());
    System.out.println("doc3=" + doc);

    Cursor cursor = coll.find(Filters.eq("group", "groupA"), FindOptions.sort("startTime", SortOrder.Descending));
    assertEquals(3, cursor.size());

    Iterator<Document> iter = cursor.iterator();
    Document doc1 = iter.next();
    Document doc2 = iter.next();
    Document doc3 = iter.next();
    assertEquals("test-1", doc3.get("id").toString());  // TODO: note, one can argue that this should have been last!
    assertEquals("test-3", doc2.get("id").toString());
    assertEquals("test-2", doc1.get("id").toString());
  }

[anidotnet]

I don't understand what is not working here as per your expectation?

There is one wrong assert in your test case. The correct statements should be like

assertEquals("test-1", doc3.get("id").toString());
assertEquals("test-2", doc2.get("id").toString());
assertEquals("test-3", doc1.get("id").toString());

Do you think the null value doc should come last? If it is, then there is no hard and fast rule for that. It's more like a convention adopted by different database. Like oracle puts null value at first in descending order where as mongo puts the other way around. It's the convention in nitrite that in descending order null value should come at last and in ascending order it comes first (same as mongo).

[cpotter1]

Notice I did orderBy startTime descending.

[anidotnet]

Yes. So it is working as expected. If you print docs from the cursor it shows

{id=test-3, group=groupA, startTime=2018-08-06T23:43:49.719+05:30, _id=6963428347032, _revision=1, _modified=1533579169719}
{id=test-2, group=groupA, startTime=2018-08-06T23:42:49.719+05:30, _id=6963428347031, _revision=1, _modified=1533579169719}
{id=test-1, group=groupA, _id=6963428347030, _revision=1, _modified=1533579169719}

for (Document document : cursor) {
    System.out.println(document);
}

[cpotter1]

Hmmm, mine did not respond that way. Mine returned #2 first.

…

On Mon, Aug 6, 2018 at 2:41 PM, Anindya Chatterjee ***@***.*** > wrote: Yes. So it is working as expected. If you print docs from the cursor it shows {id=test-3, group=groupA, startTime=2018-08-06T23:43:49.719+05:30, _id=6963428347032, _revision=1, _modified=1533579169719} {id=test-2, group=groupA, startTime=2018-08-06T23:42:49.719+05:30, _id=6963428347031, _revision=1, _modified=1533579169719} {id=test-1, group=groupA, _id=6963428347030, _revision=1, _modified=1533579169719} — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#96 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAoz92aqnklg6i_T-rzUcfezghFX9CWpks5uOI3IgaJpZM4Vwq6Z> .

[anidotnet]

Your initial assert statement was wrong. Just print doc1, doc2, doc3 sequentially and you will see the same result as mine.

[cpotter1]

Is there any option where I can instruct null columns to be either sorted at top or bottom?

[anidotnet]

Not at this moment.