Skip to content

fix: redesign grim reaper scythe and improve arm visibility in dark mode#77

Merged
nitrocode merged 2 commits into
mainfrom
copilot/improve-scythe-appearance
Apr 26, 2026
Merged

fix: redesign grim reaper scythe and improve arm visibility in dark mode#77
nitrocode merged 2 commits into
mainfrom
copilot/improve-scythe-appearance

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 26, 2026

The scythe blade was a small rounded blob perpendicular to the handle — indistinguishable from a golf club head. The bony arm used hardcoded mid-gray strokes (#888/#999) that look disconnected and floating in dark mode because the near-black robe disappears into the dark background.

Scythe blade

Replaced the compact oval path with a large crescent that sweeps left over the reaper's hood and comes to a pointed tip at the far left. The hood (rendered on top) naturally masks the mid-section, leaving the upper arc visible above the head and the tip visible to the left — classic grim reaper silhouette.

<!-- before: small golf-club blob going right -->
<path d="M77,16 C100,2 103,28 87,35 C85,26 80,19 77,16 Z" fill="#555"/>

<!-- after: large crescent arcing left over the hood -->
<path d="M77,16 C72,6 55,2 38,5 C20,8 6,20 6,32 C6,44 22,48 40,38 C56,28 72,20 77,16 Z" class="reaper-scythe-blade"/>

Arm / hand

  • Extended finger paths so individual fingers read at small render sizes.
  • Replaced inline stroke attributes with CSS classes (reaper-scythe-handle, reaper-scythe-blade, reaper-bone) for theme-aware coloring.

Theme-aware colors (styles/scary-features.css)

Element Dark mode (default) Light mode
Scythe handle/blade #aaa #666
Bony arm & fingers #ccc #999

Lighter values in dark mode make the bones read as intentionally skeletal rather than barely-visible gray fragments floating without a body.

Summary by CodeRabbit

  • Style

    • Refactored the grim reaper illustration for improved visual presentation and code structure.
  • New Features

    • Enhanced the grim reaper illustration with theme-aware styling that automatically adapts to dark and light mode preferences.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a33257e-b173-4b73-9ec0-6cc589e6c301

📥 Commits

Reviewing files that changed from the base of the PR and between a0b3ce4 and 6355548.

📒 Files selected for processing (3)
  • index.html
  • styles.css
  • styles/scary-features.css

📝 Walkthrough

Walkthrough

Fool! Dis PR refactors da Grim Reaper SVG component, ya heard? It moves from inline stroke and fill attributes to CSS classes—reaper-scythe-handle, reaper-scythe-blade, and reaper-bone. I pity da fool who don't also update da path geometries fo' da scythe blade and bony fingers! Theme-aware colors added too, sucka!

Changes

Cohort / File(s) Summary
SVG Markup Refactoring
index.html
Removed inline styling attributes and applied CSS classes (reaper-scythe-handle, reaper-scythe-blade, reaper-bone) to SVG elements. Updated path geometries for scythe blade and bony fingers elements.
Theme-Aware Styling
styles/scary-features.css
Added CSS class rules for reaper SVG components with dark-mode defaults and light-mode overrides using :root[data-theme="light"] selector to maintain readability across themes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • nitrocode
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: redesigning the grim reaper scythe geometry and improving arm visibility through theme-aware CSS colors for dark mode.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copilot/improve-scythe-appearance

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 26, 2026

👁️ PR Preview

🚀 Open Preview

Deployed from commit 194a0dc · Updates on every push to this PR
(Preview is removed automatically when the PR is closed.)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fd1cb0d) to head (194a0dc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          233       233           
  Branches       107       107           
=========================================
  Hits           233       233           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1cb0d...194a0dc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nitrocode
Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 26, 2026

@copilot resolve the merge conflicts in this pull request

Resolved in 194a0dc. The conflict was that styles.css was deleted on main (added to .gitignore as a generated file) while our branch had modified it. Merged main and accepted the deletion — the file is now correctly excluded from tracking. All 253 unit tests still pass.

@nitrocode nitrocode merged commit 3db9429 into main Apr 26, 2026
10 checks passed
@nitrocode nitrocode deleted the copilot/improve-scythe-appearance branch April 26, 2026 16:03
github-actions Bot added a commit that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants