fix: stop GitHub corner and theme toggle from being clipped on scroll#88
Conversation
… scroll Agent-Logs-Url: https://github.com/nitrocode/token-deathclock/sessions/ca06916c-4d2b-4b8a-b9f3-3b98ff0628b0 Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
📝 WalkthroughWalkthroughI pity the fool who miss this change, fool! This here CSS update be replacin' the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes I'm tellin' ya, fool, this be a simple CSS property swap with comment clarification. Ain't no logic changes, ain't no complex interactions. Just one file, one property, straightforward as it come. Any fool can review this in no time! 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
👁️ PR Preview
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 242 242
Branches 109 109
=========================================
Hits 242 242
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@styles/base.css`:
- Line 14: The change in styles/base.css adds "overflow-x: clip" but the
compiled stylesheet (styles.css) wasn't regenerated; run the existing build step
(npm run build:css which invokes scripts/build-css.js) to rebuild styles.css
before committing or testing so the generated CSS reflects the change, and
ensure styles.css is updated in the PR (or add a note to CI to run build:css).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
overflow-x: hiddenon<html>creates a scroll container, causingposition: fixedchildren (GitHub corner, theme toggle) to be clipped by thehtmloverflow box as the page scrolls rather than staying anchored to the viewport.Change
styles/base.css:overflow-x: hidden→overflow-x: clipon thehtmlruleclipblocks horizontal overflow identically tohiddenbut does not establish a scroll container, so fixed elements remain viewport-anchored on scroll. Theoverflow-x: hiddenonbodyis preserved — it handles the iOS Safari case wherebodyacting as scroll container would re-anchor fixed elements.Summary by CodeRabbit