feat: removal of ackee-blockchain.solidity-tools and consensys.vscode-solidity-auditor #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bbjubjub2494
left a comment
bbjubjub2494
left a comment
There was a problem hiding this comment.
Any rationale for that? Did we decide not to carry vscode extensions?
Collaborator
Author
|
@bbjubjub2494 exactly, and less maintenance burden |
bbjubjub2494
previously approved these changes
Sep 15, 2025
Collaborator
bbjubjub2494
left a comment
bbjubjub2494
left a comment
There was a problem hiding this comment.
Concept ACK. I would put a throw instead of deleting the entry so people know why it was removed.
selfuryon
previously approved these changes
Sep 24, 2025
selfuryon
dismissed stale reviews from bbjubjub2494 and themself
via
61536b9
selfuryon
force-pushed
the
remove-vscode-extensions
branch
from
61536b9 to
adb4754
Compare
…-solidity-auditor chore(pkgs): add throw for deleted packages
selfuryon
force-pushed
the
remove-vscode-extensions
branch
from
adb4754 to
b06d233
Compare
Collaborator
|
I just tried to add |
selfuryon
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.