tests: Remove the test link farm #1898
Conversation
|
We'll have to update the This could be another PR; this PR could just disable the |
|
Yeah I tried this PR to see what it would do, but I think we ought to wait for nix-community/buildbot-nix#217 to reduce the clutter a bit |
traxys
force-pushed
the
no_link_farm
branch
2 times, most recently
from
420b7ab to
51b5590
Compare
traxys
changed the title
flake-modules/dev/launch-test.sh
Outdated
|
|
||
| run_tests() { | ||
| # Add the prefix "checks.${system}." to each argument | ||
| if ! "${NIXVIM_NIX_COMMAND}" build -f . "${@/#/checks.${NIXVIM_SYSTEM}.}"; then |
There was a problem hiding this comment.
Can we use --file instead of -f? I prefer using long-form options in scripts since anyone can follow their meaning, even if unfamiliar with the specific command's options.
There was a problem hiding this comment.
Also, does nix build -f . produce ./result? I'm wondering if we can speed up the generate-files build by doing all builds in one step?
There was a problem hiding this comment.
It does for each of the derivations passed to the command line.
I don't see how can be do all the builds in "one" step, I already pass all the builds to a single nix invocation :/
There was a problem hiding this comment.
Sorry, which comment are you replying to?
There was a problem hiding this comment.
I'm wondering if we can speed up the generate-files build by doing all builds in one step?
The `tests` command can either launch all tests (without any arguments), a specific test with `-t/--test` or choose a test with `-i/--interactive`
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
No issues from me assuming everything works and tests pass etc
4 participants
No description provided.