Skip to content

Enhance DialogData.js comments for expanded property getter and setter methods #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmahesh-cainc merged 2 commits into from
Oct 9, 2025
Merged

Enhance DialogData.js comments for expanded property getter and setter methods #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3cd8e7
Initial plan
Copilot Oct 8, 2025
6aed9e5
Update DialogData.js comments to be more detailed and span two lines
Copilot Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/RoleObjects/DialogData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import AccessibilityObject from './AccessibilityObject';

export default class DialogData extends AccessibilityObject {
/**
* Sets whether the element should get expanded
* Sets whether the dialog element is expanded or collapsed.
* When expanded, the dialog's content is visible to the user.
* @access public
* @param {boolean} val - true if expanded, false if not expanded, undefined if the field is unset
*/
Expand All @@ -11,7 +12,8 @@ export default class DialogData extends AccessibilityObject {
}

/**
* Retrieves whether expanded
* Retrieves whether the dialog element is expanded or collapsed.
* Checks the 'aria-expanded' property in the underlying React props.
* @access public
* @returns {boolean} true if expanded, false if not expanded, undefined if the field is unset
*/
Expand Down