🐛 Bug: impossible to submit new record form with defaut values

[jbricout007]

Please confirm that the bug report does not already exist

• I confirm there is no existing issue for this bug.

Steps to reproduce

I have a table with some mandatory fields, wich have default values such as zero (numeric fields)
I try to add a new record by clicking on "new record-form"
The button is not available : I have to change the default value to submit the record
The problem does not appear with "new record-grid" function

Desired Behavior

It normally has to be possible to sumbit the new form without changing default values to add a new record

Project Details

Node: v18.18.2
Arch: x64
Platform: linux
Docker: false
RootDB: pg
PackageVersion: 0.204.0

Attachments

[dosubot]

Hello, @jbricout007! 👋 I'm here to help you with any bugs, questions, or contributions you have. Let's tackle this together!

The "Save" button is not available when trying to submit a new record form with default values because the disableSubmitBtn state is likely set to true under certain conditions. This state controls the availability of the "Save" button.

To fix this issue and allow submission without changing the default values, you need to ensure that the disableSubmitBtn state is set to false when the form is in a valid state, even if the default values are not changed.

Here are the specific conditions under which the disableSubmitBtn state is set to true:

const disableSubmitBtn = computed(() => {
  return (
    !formState.value.title ||
    !formState.value.uidt ||
    saving.value ||
    (isEdit.value && formState.value.uidt !== column.value?.uidt && !isFullUpdateAllowed.value)
  )
})

This means disableSubmitBtn will be true if any of the following conditions are met:

1. formState.value.title is falsy (e.g., empty or null).
2. formState.value.uidt is falsy.
3. saving.value is true.
4. It is in edit mode (isEdit.value is true), the uidt of the form state does not match the uidt of the column, and a full update is not allowed (isFullUpdateAllowed.value) ^[1].

Additionally, there are event listeners and watchers in the EditOrAdd.vue component that might be affecting the disableSubmitBtn state based on user interactions or form state changes. Specifically, the watch on formState and the @input event on the input fields can influence the form state and potentially the disableSubmitBtn state ^[1].

To resolve this issue, you need to adjust the logic that sets disableSubmitBtn to ensure that it does not disable the button when the form is valid, even if the values are default. This way, the "Save" button will be available for submission even if the default values are not changed.

To continue talking to Dosu, mention @dosu.

[dstala]

@jbricout007 if i create a table from nocodb & set a field with default value - i am able to create new record by using form mode. are you connecting to external db in this case? if so, can you let us know if the field has any additional constraints set?

[dstala]

also, can you upgrade to latest version of nocodb. easy for us to support that way

[salim-b]

I think I observed the same issue in older NocoDB versions: In a table with a column having a DEFAULT value as well as a NOT NULL constraint set from an external PostgreSQL data source, a new row could only be added via form view when a value was explicitly provided for that column (otherwise an error was displayed that the column cannot be NULL). Via grid view, it always worked.

In the latest NocoDB stable release (v0.251.1), this issue doesn't seem to be present anymore (or at least I can't reproduce it anymore). Hope that helps narrowing it down.

[jbricout007]

@jbricout007 if i create a table from nocodb & set a field with default value - i am able to create new record by using form mode. are you connecting to external db in this case? if so, can you let us know if the field has any additional constraints set?

hi @dstala : an upgrade will take place in a few times. Perhaps it will be corrected seeing the explanation of @salim-b
Yes we are connected to an external database (postgresql) but the field doses not have any constraint in the database itself : we just put "NOT null" in nocodb for that field and a default value (0)

[dstala]

Thanks for the details. Please reopen this ticket once you upgrade & if issue still persists.