🐛 Bug: Can't delete integration

[OnlyFart]

Please confirm that the bug report does not already exist

• I confirm there is no existing issue for this bug.

Steps to reproduce

1. Create integration
2. Try delete intergration

Desired Behavior

Integration delete

Project Details

Docker, 0.252

Attachments

[dosubot]

Hello, @OnlyFart! I'm here to help you with any bugs, questions, or contributions you may have. Let's tackle this issue together!

To resolve the TypeError "Cannot read properties of undefined (reading 'includes')" when attempting to delete an integration, ensure that the extensionId being passed to the delete method is not undefined or null. The error suggests that extensionId is not properly defined or passed.

Here is the relevant delete method from the Extension class:

static async delete(
    context: NcContext,
    extensionId: any,
    ncMeta = Noco.ncMeta,
  ) {
    const res = await ncMeta.metaDelete(
      context.workspace_id,
      context.base_id,
      MetaTable.EXTENSIONS,
      extensionId,
    );

    await NocoCache.deepDel(
      `${CacheScope.EXTENSION}:${extensionId}`,
      CacheDelDirection.CHILD_TO_PARENT,
    );

    return res;
  }
}

To prevent the error, add a check to ensure extensionId is defined before proceeding with the deletion:

static async delete(
    context: NcContext,
    extensionId: any,
    ncMeta = Noco.ncMeta,
  ) {
    if (!extensionId) {
      throw new Error("extensionId is required and cannot be undefined or null");
    }

    const res = await ncMeta.metaDelete(
      context.workspace_id,
      context.base_id,
      MetaTable.EXTENSIONS,
      extensionId,
    );

    await NocoCache.deepDel(
      `${CacheScope.EXTENSION}:${extensionId}`,
      CacheDelDirection.CHILD_TO_PARENT,
    );

    return res;
  }
}

This check will ensure that extensionId is not undefined or null, thus preventing the TypeError ^[1].

To continue talking to Dosu, mention @dosu.