fix: group empty string as null #10060

DarkPhoenix2704 · 2024-12-16T17:12:17Z

Change Summary

#10057

Change type

fix: (bug fix for the user, not a fix to a build script)

coderabbitai · 2024-12-16T17:12:28Z

📝 Walkthrough

Walkthrough

The pull request introduces changes to two key files: useKanbanViewStore.ts and BaseModelSqlv2.ts. In the kanban view store, modifications enhance data management logic, particularly around grouping fields, stack handling, and error management. The BaseModelSqlv2 file updates focus on improving grouped list queries, with more robust handling of null and empty string values in grouping columns and more precise filter application.

Changes

File	Change Summary
`packages/nc-gui/composables/useKanbanViewStore.ts`	- Enhanced type checking for `data.key` in `loadKanbanData` - Updated `loadMoreKanbanData` condition for `where` clause - Improved `loadKanbanMeta` for handling grouping field options - Modified `deleteStack` to handle record grouping updates - Improved error handling in asynchronous functions
`packages/nocodb/src/db/BaseModelSqlv2.ts`	- Updated `groupedList` method to handle null and empty string values - Enhanced `groupedListCount` method with more robust filter and sort application - Improved query construction for grouped queries

Suggested labels

🐛 Type: Bug, size:M, 👓 Scope : View, lgtm

Suggested reviewers

DarkPhoenix2704
dstala
pranavxc

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-12-16T17:23:45Z

Uffizzi Preview deployment-59140 was deleted.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (3)

packages/nocodb/src/db/BaseModelSqlv2.ts (3)
4486-4489: Standardize empty string handling for SingleSelect columns

Added consistent handling of empty strings by converting them to NULL using COALESCE and NULLIF. This ensures uniform behavior across the application.

This change aligns with the best practice of treating empty strings as NULL values in database operations, which helps maintain data consistency and simplifies querying.

8072-8074: Improve group value handling for empty strings

Enhanced the grouping logic to:

Handle both NULL and empty string values consistently

Explicitly convert empty strings to NULL after trimming

Consider extracting the empty string check into a reusable utility function since this pattern may be needed elsewhere:
function isEmptyString(val: any): boolean {
  return typeof val === 'string' && val.trim() === '';
}
Also applies to: 8096-8101

8137-8137: Enhance GROUP BY handling for empty strings

Modified the GROUP BY query to use COALESCE and NULLIF for consistent empty string handling across different SQL dialects. Also added proper column configuration to support this change.

This change improves cross-database compatibility by using standard SQL functions. The column configuration addition makes the code more maintainable.

Also applies to: 8192-8196

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 635d14d and a476e8e.

📒 Files selected for processing (2)

packages/nc-gui/composables/useKanbanViewStore.ts (2 hunks)
packages/nocodb/src/db/BaseModelSqlv2.ts (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/nc-gui/composables/useKanbanViewStore.ts

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/nocodb/src/db/BaseModelSqlv2.ts (1)

Line range hint 4486-8205: Consider adding unit tests for empty string handling

While the implementation looks good, it would be beneficial to add comprehensive unit tests to verify the behavior of empty string handling across different scenarios:

SingleSelect field with empty string

SingleSelect field with NULL

Grouping by SingleSelect field with mixed empty strings and NULLs

Would you like me to help create unit tests for these scenarios?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7837570 and 932ddce.

📒 Files selected for processing (2)

packages/nc-gui/composables/useKanbanViewStore.ts (2 hunks)
packages/nocodb/src/db/BaseModelSqlv2.ts (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/nc-gui/composables/useKanbanViewStore.ts

🔇 Additional comments (4)

packages/nocodb/src/db/BaseModelSqlv2.ts (4)

4486-4489: LGTM: Proper handling of empty strings for SingleSelect fields

The implementation correctly converts empty strings to NULL using COALESCE and NULLIF for SingleSelect fields. This ensures consistent behavior across the application.

8072-8078: LGTM: Consistent handling of NULL and empty strings in grouping

The WHERE clause properly handles both NULL values and empty strings for SingleSelect fields. The implementation uses proper query builder methods and maintains consistency with the rest of the codebase.

8141-8146: LGTM: Proper GROUP BY handling for SingleSelect fields

The implementation correctly uses COALESCE and NULLIF in the GROUP BY clause to ensure consistent grouping behavior for SingleSelect fields with empty strings.

8201-8205: LGTM: Consistent column selection for grouped queries

The column selection is properly updated to match the new grouping behavior, maintaining consistency with the empty string handling changes.

o1lab force-pushed the nc-fix-group-empty-string-as-null branch 2 times, most recently from 635d14d to a476e8e Compare December 16, 2024 18:11

coderabbitai bot reviewed Dec 16, 2024

View reviewed changes

DarkPhoenix2704 mentioned this pull request Dec 16, 2024

🐛 Bug: Rows Inserted via REST API Not Visible in Kanban View #10057

Closed

1 task

o1lab force-pushed the nc-fix-group-empty-string-as-null branch from a476e8e to 7837570 Compare December 16, 2024 19:09

DarkPhoenix2704 added 5 commits December 17, 2024 13:42

fix: group empty string as null for kanban

ae96f57

fix: load more data where filter update

4dc3666

fix: count query colaesce

862232f

fix:apply conditions only for Single Select

f1ed7cb

fix: remove trim

932ddce

o1lab force-pushed the nc-fix-group-empty-string-as-null branch from 7837570 to 932ddce Compare December 17, 2024 13:42

coderabbitai bot reviewed Dec 17, 2024

View reviewed changes

mertmit approved these changes Dec 17, 2024

View reviewed changes

mertmit merged commit 32adc7d into develop Dec 17, 2024
11 checks passed

mertmit deleted the nc-fix-group-empty-string-as-null branch December 17, 2024 13:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: group empty string as null #10060

fix: group empty string as null #10060

Uh oh!

DarkPhoenix2704 commented Dec 16, 2024

Uh oh!

coderabbitai bot commented Dec 16, 2024 •

edited

Loading

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Dec 16, 2024 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix: group empty string as null #10060

fix: group empty string as null #10060

Uh oh!

Conversation

DarkPhoenix2704 commented Dec 16, 2024

Change Summary

Change type

Uh oh!

coderabbitai bot commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Dec 16, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Dec 16, 2024 •

edited

Loading