fix: use proper reference for related model id

[mertmit]

Change Summary

We are listing from MetaTable.COL_RELATIONS which is colOptions itself so we should directly access the required prop.

Issue pointed & fix provided by https://github.com/gaurav-peswani-truva
Ref: #9728 (comment)

Change type

• fix: (bug fix for the user, not a fix to a build script)

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces modifications to two files: packages/nocodb-sdk/src/lib/Api.ts and packages/nocodb/src/models/Column.ts. In the SDK, the dbTableRow interface is updated with new parameters for the list and create methods, enabling more flexible data retrieval and row creation. In the Column.ts file, a type assertion for the linkCol variable is refined to improve type safety, with no significant changes to the method's core functionality.

Changes

File	Change Summary
packages/nocodb-sdk/src/lib/Api.ts	- Added getHiddenColumns parameter to list method - Updated create method to include before and undo query parameters
packages/nocodb/src/models/Column.ts	- Modified type assertion for linkCol in update method to use LinksColumn type

Possibly related PRs

• fix: barcode on formula #9493: Modifies the Column class in Column.ts, relevant to column identifier handling
• fix: Avoid deleting meta on LTAR description update - WIP #9684: Involves changes to the Column class methods for column data management
• fix: Column update related bugs #10111: Focuses on bug fixes related to column updates in ColumnsService

Suggested labels

🐛 Type: Bug, size:S, lgtm

Suggested reviewers

• dstala
• pranavxc

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/nocodb/src/models/Column.ts (1)

1557-1557: Ensure type safety before casting to LinksColumn.

While this type assertion helps us access fk_related_model_id, if linkCol can be anything other than a LinksColumn at runtime, this cast may lead to issues in production. Consider performing a runtime check or implementing a type guard to confirm that linkCol is indeed a LinksColumn before casting.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02027ed and 5aa04ae.

📒 Files selected for processing (2)

• packages/nocodb-sdk/src/lib/Api.ts (10 hunks)
• packages/nocodb/src/models/Column.ts (1 hunks)

🔇 Additional comments (3)

packages/nocodb-sdk/src/lib/Api.ts (3)

8216-8217: LGTM: Added getHiddenColumns parameter consistently

The addition of getHiddenColumns parameter to list methods is consistent and provides good flexibility for fetching hidden columns when needed.

Also applies to: 9090-9090

---

8259-8262: LGTM: Added record manipulation parameters

The addition of before and undo parameters to create/bulkCreate methods provides useful functionality for:

• Positioning records using before parameter
• Supporting undo operations using undo parameter

The implementation is consistent across different methods.

Also applies to: 8607-8609, 9133-9136, 12170-12171

---

12313-12349: LGTM: Added record move functionality

The new move method is well-implemented with:

• Clear documentation
• Proper typing
• Consistent parameter naming (before parameter matches create methods)
• Returns proper response type

This provides good functionality for record reordering.

[github-actions]

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/nocodb/nocodb/pull/10170

⚙️ Updating now by workflow run 12581671859.

What is Uffizzi? Learn more!