Nc fix/custom url follow up

[rameshmane7218]

Change Summary

Provide summary of changes with issue number if any.

Change type

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces several changes across different components and files in the NocoDB project. A new PageDoesNotExist Vue component is added for handling non-existent pages. A middleware for URL redirection is implemented in 01.redirect.global.ts. A new CustomUrl model is created in CustomUrl.ts with various static methods for managing custom URLs. Additionally, a minor change involves removing an unused import in the ViewCreate.vue component.

Changes

File	Change Summary
packages/nc-gui/components/dlg/ViewCreate.vue	Removed import of capitalize function from @vue/runtime-core
packages/nc-gui/components/general/PageDoesNotExist.vue	New Vue component for displaying a "Page Not Found" message with customizable icon and title
packages/nc-gui/middleware/01.redirect.global.ts	Added global middleware for handling URL redirection based on query parameters
packages/nocodb/src/models/CustomUrl.ts	New CustomUrl class with multiple static methods for managing custom URLs

Suggested Labels

🐛 Type: Bug, size:S, lgtm

Suggested Reviewers

• dstala
• DarkPhoenix2704

Sequence Diagram

sequenceDiagram
    participant User
    participant Middleware
    participant Router
    
    User->>Middleware: Request with query params
    Middleware->>Middleware: Parse hash-redirect and hash-query-params
    Middleware->>Router: Construct new URL
    Router->>User: Redirect to new URL

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

packages/nc-gui/components/general/PageDoesNotExist.vue (1)

1-16: Consider usage of SSR & route navigation.

Since this is a Nuxt/Vue component, ensure that calling navigateTo('/') directly from the button click meets your routing requirements. In SSR scenarios, or if the page is loaded server-side, referencing global browser objects or certain runtime methods might cause unexpected behavior. If this component is strictly client-side, then this approach is fine. Otherwise, you may consider a Nuxt-provided navigation API or an <nuxt-link> for safer, more consistent routing.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21af8fb and c46da6e.

⛔ Files ignored due to path filters (1)

• packages/nc-gui/lang/en.json is excluded by !**/*.json

📒 Files selected for processing (4)

• packages/nc-gui/components/dlg/ViewCreate.vue (0 hunks)
• packages/nc-gui/components/general/PageDoesNotExist.vue (1 hunks)
• packages/nc-gui/middleware/01.redirect.global.ts (1 hunks)
• packages/nocodb/src/models/CustomUrl.ts (1 hunks)

💤 Files with no reviewable changes (1)

• packages/nc-gui/components/dlg/ViewCreate.vue

🔇 Additional comments (1)

packages/nc-gui/middleware/01.redirect.global.ts (1)

1-29: ⚠️ Potential issue

Verify SSR safety & sanitized URL usage.

1. SSR caution: Using window.location within a Nuxt route middleware can fail when executed in a server-side context. If you plan to run this middleware server-side, consider checking process.client before accessing window or refactor to a purely client-side guard.

2. Potential XSS/URL validation: The user-supplied hash-redirect and hash-query-params are decoded and redirected without validation. Attackers could inject malicious fragments that lead to phishing or an untrusted domain. At minimum, ensure that the domain is restricted or sanitized to avoid unsafe redirects.

Would you like me to generate a script to search for references to 01.redirect.global.ts in the codebase, verifying SSR usage or potential sanitization steps?

[github-actions]

Uffizzi Preview deployment-59470 was deleted.