fix: datetime lookup bug

[DarkPhoenix2704]

Change Summary

Time format is not applied to Lookup DateTime
Sync PR

Change type

• fix: (bug fix for the user, not a fix to a build script)

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the getDateTimeValue function in packages/nc-gui/utils/dataUtils.ts. An import for timeFormatsObj is added, and the function now retrieves the column metadata (columnMeta) to dynamically determine the proper time format. A new variable (is12hrFormat) is introduced to check for 12-hour time formatting, which conditionally affects the construction of the dateTimeFormat.

Changes

File	Change Summary
packages/nc-gui/.../dataUtils.ts	- Added an import for timeFormatsObj from ../components/smartsheet/grid/canvas/utils/cell. - Modified getDateTimeValue to retrieve columnMeta. - Introduced is12hrFormat and conditionally applied the appropriate time format using timeFormatsObj.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant F as getDateTimeValue
    participant M as ColumnMeta
    participant T as timeFormatsObj

    C->>F: Call getDateTimeValue(column)
    F->>M: Retrieve column meta-data from column
    F->>F: Determine is12hrFormat based on columnMeta
    alt is12hrFormat true
        F->>T: Use 12-hour format from timeFormatsObj
    else is12hrFormat false
        F->>T: Use default/24-hour format from timeFormatsObj
    end
    F-->>C: Return formatted dateTime value

Loading

Possibly related PRs

• fix: Invalid Date error format in calendar view #9809: Also modifies the getDateTimeValue function to adjust date parsing logic, providing a code-level connection between the changes.

Suggested labels

🐛 Type: Bug, size:S, lgtm

Suggested reviewers

• dstala

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22174f6 and d0969eb.

📒 Files selected for processing (1)

• packages/nc-gui/utils/dataUtils.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: release-docker / buildx
• GitHub Check: unit-tests-pg
• GitHub Check: unit-tests

🔇 Additional comments (2)

packages/nc-gui/utils/dataUtils.ts (2)

26-26: Added required import for timeFormatsObj

The addition of this import is necessary for the fix implemented below, allowing the function to properly format time based on user preferences.

---

517-523: Fixed datetime format bug correctly

This change properly fixes the datetime lookup bug by:

1. Retrieving the column metadata using parseProp
2. Correctly accessing format properties with fallback defaults
3. Introducing is12hrFormat to determine the appropriate time format
4. Conditionally applying the correct time format based on user preference

The implementation now correctly handles both 12-hour and 24-hour time formats based on column metadata.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.