fix(nc-gui): expanded form issue and kanban view test fail issue

[rameshmane7218]

Change Summary

Provide summary of changes with issue number if any.

Change type

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the expanded form component by restructuring its state management and computed properties. New reactive variables (isLoading, isSaving) and an enhanced expanded form store are introduced. The component now uses a reactive field injection with an updated type, and its computed property for fields now conditionally favors meta fields while filtering out system and read-only entries. Redundant code has been removed, and additional comments have been added for clarity.

Changes

File	Summary
packages/nc-gui/.../expanded-form/index.vue	Added new reactive variables (isLoading, isSaving), restructured expandedFormStore destructuring, updated reactive field injection, enhanced computed fields logic, and removed redundant state declarations.

Sequence Diagram(s)

sequenceDiagram
    participant EF as ExpandedForm Component
    participant RS as ExpandedForm Store
    participant CP as Computed Property Logic

    EF->>RS: Initialize reactive states (isLoading, isSaving, expandedFormStore)
    EF->>CP: Invoke computed property for fields
    CP-->>EF: Return processed fields (using meta fields or injected fields)
    EF->>UI: Render updated form fields

Loading

Possibly related PRs

• Nc nc fix/kanban order #10316: Enhances state management and computed properties within the expanded form component.
• Refactor: Do not pass expanded form store as prop #10279: Restructures usage of the expanded form store with a focus on state handling.
• Nc fix/expanded for UI changes #8452: Updates reactive variable initialization and computed property logic in the same component file.

Suggested labels

🐛 Type: Bug, 👓 Scope : View, size:M, lgtm

Suggested reviewers

• dstala

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e1c303 and 414f328.

📒 Files selected for processing (1)

• packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: release-docker / buildx
• GitHub Check: pre-build-for-playwright / playwright
• GitHub Check: unit-tests-pg
• GitHub Check: unit-tests

🔇 Additional comments (6)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (6)

90-91: LGTM: Proper injection of isKanban reference

The injection of the Kanban flag with a default value of false is correctly implemented.

---

92-93: LGTM: Proper provider implementation for meta data

The meta data is correctly provided to child components.

---

94-97: LGTM: Added reactive state variables

The addition of reactive references for tracking loading and saving states is a good practice that will help with UI state management.

---

98-115: LGTM: Improved expanded form store implementation

The expanded form store creation and destructuring is well organized. This helps separate concerns and makes the component more maintainable.

---

122-126: LGTM: Enhanced field injection with proper typing

The updated typing for fieldsFromParent ensures proper reactivity by using Ref<ColumnType[] | null> instead of just ColumnType[] | null. The added comments also improve code clarity.

---

128-175: LGTM: Improved fields computation logic

The enhanced computed property for fields now:

1. Has clear documentation explaining its purpose
2. Properly handles the preference for props.useMetaFields over fieldsFromParent
3. Correctly filters out system columns and read-only fields based on the isNew state
4. Returns an empty array as a fallback

This makes the component more robust and maintainable.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.