Nc fix clear sort indicator

[dstala]

Change Summary

Provide summary of changes with issue number if any.

Change type

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes introduce a new parameter, includeSortAndFilterColumns, across several modules to control the inclusion of sorting and filtering columns during data retrieval. In the UI composable, the parameter is set to true when calling loadData and an explicit clause ensures a consistent row order state. Similarly, controller methods now accept a query parameter (converted from string to boolean) and service/helper methods have been updated to accept and propagate this option.

Changes

File(s)	Change Summary
packages/nc-gui/.../useInfiniteData.ts	Sets includeSortAndFilterColumns to true in the loadData call and adds an else clause to explicitly set rowMeta.isRowOrderUpdated to false.
packages/nocodb/src/controllers/data-alias.controller.ts, packages/nocodb/src/controllers/data-table.controller.ts	Adds a new query parameter includeSortAndFilterColumns (as a string converted to boolean) to the dataList methods in both controllers.
packages/nocodb/src/helpers/getAst.ts	Introduces the optional parameter includeSortAndFilterColumns and adds logic to retrieve and include sort and filter column IDs when enabled.
packages/nocodb/src/services/data-table.service.ts, packages/nocodb/src/services/datas.service.ts	Adds an optional includeSortAndFilterColumns parameter to the signature of dataList (and getDataList) methods, propagating the option to lower layers.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant Ctrl as Controller
    participant Svc as Service
    participant H as Helper (getAst)
    
    C->>Ctrl: Request with includeSortAndFilterColumns query param
    Ctrl->>Svc: Call dataList(includeSortAndFilterColumns flag)
    Svc->>H: Process getAst if sort/filter columns needed
    H-->>Svc: Return sorting/filter information
    Svc-->>Ctrl: Return data list with sort/filter options
    Ctrl-->>C: Send final response

Loading

Possibly related PRs

• Nc fix/miscellaneous #9447: Aligns with the inclusion of includeSortAndFilterColumns in loadData and dataList methods across controllers and services.
• chore: sync various #10519: Directly relates to adding the includeSortAndFilterColumns parameter in the useInfiniteData function and the corresponding controller modifications.
• chore: various fixes #10124: Shares similar modifications introducing the includeSortAndFilterColumns parameter in data retrieval methods for consistent sorting and filtering functionality.

Suggested labels

🐛 Type: Bug, size:S, lgtm

Suggested reviewers

• rameshmane7218
• DarkPhoenix2704

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8b2438 and a723dd6.

📒 Files selected for processing (6)

• packages/nc-gui/composables/useInfiniteData.ts (2 hunks)
• packages/nocodb/src/controllers/data-alias.controller.ts (2 hunks)
• packages/nocodb/src/controllers/data-table.controller.ts (1 hunks)
• packages/nocodb/src/helpers/getAst.ts (7 hunks)
• packages/nocodb/src/services/data-table.service.ts (2 hunks)
• packages/nocodb/src/services/datas.service.ts (4 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.