add project Id with filterparent requests #4320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vijay Kumar Rathore <professional.vijay8492@gmail.com>
pranavxc
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijay Kumar Rathore professional.vijay8492@gmail.com
Change Summary
If user try to update child filters, it's getting error as user not allowed. This PR fixes this issue.
Change type
Test/ Verification
Provide summary of changes.
The error is happening when filterParentId is sent in request parameter. In backend projectId is not searched with filter parent and noco backend consider all these requests as unauthorized as authorization is project based.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of