Skip to content

fix(nc-gui): get public gallery data from sharedView.view #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix(nc-gui): get public gallery data from sharedView.view #4855

merged 1 commit into from
Jan 17, 2023

Conversation

@wingkwong
Copy link
Contributor

@wingkwong wingkwong commented Jan 16, 2023

Change Summary

ref: #4664

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

image

@wingkwong wingkwong requested a review from mustafapc19 January 16, 2023 10:56
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2023 •
edited
Loading

Uffizzi Preview deployment-11244 was deleted.

@o1lab o1lab merged commit 8a79feb into develop Jan 17, 2023
@o1lab o1lab deleted the fix/gallery-cover-image-share-view branch January 17, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mustafapc19 mustafapc19 Awaiting requested review from mustafapc19

Assignees

@mustafapc19 mustafapc19

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wingkwong @o1lab @mustafapc19