feat: UX improvement: Remove copy invite token button for register users #4934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed users Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: beejaybot <akisanyamobolaji@gmail.com> Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com> Co-authored-by: Mayomi Ayandiran <ayandiranmayomi@gmail.com>
wingkwong
suggested changes
Jan 27, 2023
Contributor
wingkwong
left a comment
wingkwong
left a comment
There was a problem hiding this comment.
L112 - 116 is not necessary. You can just do in this way.
<a-dropdown v-if="user.invite_token" :trigger="['click']" class="flex" placement="bottomRight" overlay-class-name="nc-dropdown-user-mgmt">
wingkwong
added
the
🚧 Status: Changes Requested
Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: beejaybot <akisanyamobolaji@gmail.com> Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com> Co-authored-by: Mayomi Ayandiran <ayandiranmayomi@gmail.com>
Contributor
Author
Hi @wingkwong, |
wingkwong
removed
the
🚧 Status: Changes Requested
wingkwong
approved these changes
Jan 30, 2023
Contributor
wingkwong
left a comment
wingkwong
left a comment
There was a problem hiding this comment.
Wait for the test result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
ref: #4617
For better UX and to reduce user confusion these options should only be shown for users that are not yet registered successfully.
Change type
Additional information / screenshots (optional)
https://www.loom.com/share/976667350a174255a9cf83303c859344