Skip to content

Conversation

@pranavxc
Copy link
Member

@pranavxc pranavxc commented Jan 30, 2023

Change Summary

  • Create a project
    • Focus on the input field
    • Generate default project name
  • Invite user modal close on escape key press ( after inviting a user ) '
  • Add new row Alt R : auto focus (edit mode) on first cell in newly added row
  • Right align cell for numerical fields (number, decimal, currency, duration, percent). Expanded form, should be left aligned
  • Column edit modal: clicking on right hand empty space of column name input field, should disable text selection & move cursor to the end of text; also clicking in between text should place cursor in that position. Also applicable for rename modal
  • Duplicate table presence alert message not displayed during table rename (it is present only for table create)

re #4573

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@pranavxc pranavxc requested a review from dstala January 30, 2023 05:55
@dstala
Copy link
Member

dstala commented Jan 30, 2023

Verification status

  • Create a project
    • Focus on the input field
    • Generate default project name
      • Typing a project name was not allowed. Text selection was persistent on one character
  • Invite user modal close on escape key press ( after inviting a user ) '
    • Works only after click on the modal showing invite URL
  • Add new row Alt R : auto focus (edit mode) on first cell in newly added row
  • Right align cell for numerical fields (number, decimal, currency, duration, percent). Expanded form, should be left aligned
    • Verified for number, decimal, currency, duration, percent
    • Additionally - can we do it for :: rollup, formula & lookup - if we know result is a number (Airtable does this)
  • Column edit modal: clicking on right hand empty space of column name input field, should disable text selection & move cursor to the end of text; also clicking in between text should place cursor in that position. Also applicable for rename modal
  • Duplicate table presence alert message not displayed during table rename (it is present only for table create)

Broken

  • Select cell & enter : doesn't toggle to edit mode
  • Select & start typing : doesn't toggle to edit mode

@pranavxc pranavxc added the trigger-CI force trigger CI even if PR in draft mode label Jan 31, 2023
@dstala
Copy link
Member

dstala commented Jan 31, 2023

issue that we saw with collaborator, is also happening with URL. so two fixes needed

  • URL overflow on scroll
  • URL field- selection mode, start typing - should accept characters
  • Unit test needs fix

@pranavxc pranavxc requested a review from wingkwong January 31, 2023 11:26
@pranavxc pranavxc marked this pull request as ready for review January 31, 2023 11:26
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

Uffizzi Preview deployment-12896 was deleted.

pranavxc and others added 20 commits February 1, 2023 11:53
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Copy link
Contributor

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new row Alt R : auto focus (edit mode) on first cell in newly added row

Just wanna double confirm that if this is expected. I create the third row, then press ALT + R on cell B3, should it auto focus on A3 or A4?

image

Right align cell for numerical fields (number, decimal, currency, duration, percent). Expanded form, should be left aligned

It should be left aligned in expanded form.

image

Signed-off-by: Pranav C <pranavxc@gmail.com>
isGrid will be true and isForm will be true when inside expanded form

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
Copy link
Member Author

pranavxc commented Feb 1, 2023

Add new row Alt R : auto focus (edit mode) on first cell in newly added row

Just wanna double confirm that if this is expected. I create the third row, then press ALT + R on cell B3, should it auto focus on A3 or A4?

image

Right align cell for numerical fields (number, decimal, currency, duration, percent). Expanded form, should be left aligned

It should be left aligned in expanded form.

image
  1. It will focus on the first input regardless of the previous cell
  2. Fixed now, good catch 👍 .

Signed-off-by: Pranav C <pranavxc@gmail.com>
@dstala dstala merged commit 7514ad6 into develop Feb 2, 2023
@dstala dstala deleted the fix/misc branch February 2, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trigger-CI force trigger CI even if PR in draft mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants